Skip to content

[harfbuzz] update to 7.0.0#29618

Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom
quyykk:update-harfbuzz-7.0.0
Mar 13, 2023
Merged

[harfbuzz] update to 7.0.0#29618
dan-shaw merged 1 commit intomicrosoft:masterfrom
quyykk:update-harfbuzz-7.0.0

Conversation

@quyykk
Copy link
Contributor

@quyykk quyykk commented Feb 12, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Feb 12, 2023
View reviewed changes
@LilyWangLL LilyWangLL added category:port-update The issue is with a library, which is requesting update new revision requires:all-feature-testing labels Feb 13, 2023
@LilyWangLL
Copy link
Contributor

LilyWangLL commented Feb 13, 2023

When installing harfbuzz[glib], vcpkg output the following warning, could you please also fix it by vcpkg_copy_tools?

-- Performing post-build validation
warning: The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets.

    E:/Lily/harfbuzz/packages/harfbuzz_x86-windows/bin/hb-info.exe

warning: The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets.

    E:/Lily/harfbuzz/packages/harfbuzz_x86-windows/debug/bin/hb-info.exe

error: Found 2 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: E:\Lily\harfbuzz\ports\harfbuzz\portfile.cmake

@LilyWangLL
Copy link
Contributor

LilyWangLL commented Feb 13, 2023

And harfbuzz[graphite2]:x64-windows-static build failed with the following error in this update.

"C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/link.exe"  /MACHINE:x64 /OUT:util/hb-shape.exe util/hb-shape.exe.p/hb-shape.cc.obj "-INCREMENTAL" "/nologo" "/release" "/nologo" "-machine:x64" "-nologo" "-debug" "/LIBPATH:E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib" "src\libharfbuzz.a" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/freetyped.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/bz2d.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/libpng16d.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/zlibd.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/brotlidec-static.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/brotlicommon-static.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/glib-2.0.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/intl.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/iconv.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/pcre2-8d.lib" "/LIBPATH:E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib" "ws2_32.lib" "winmm.lib" "/LIBPATH:E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib" "ws2_32.lib" "winmm.lib" "E:/Lily/harfbuzz/installed/x64-windows-static/debug/lib/graphite2.lib" "/SUBSYSTEM:CONSOLE" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib"
LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/RELEASE' specification
   Creating library util\hb-shape.lib and object util\hb-shape.exp
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_make_face_with_ops referenced in function _hb_graphite2_shaper_face_data_create
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_face_featureval_for_lang referenced in function _hb_graphite2_shape
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_face_find_fref referenced in function _hb_graphite2_shape
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_face_destroy referenced in function _hb_graphite2_shaper_face_data_destroy
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_fref_set_feature_value referenced in function _hb_graphite2_shape
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_featureval_destroy referenced in function _hb_graphite2_shape
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_make_seg referenced in function _hb_graphite2_shape
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_seg_destroy referenced in function _hb_graphite2_shape
libharfbuzz.a(hb-graphite2.cc.obj) : error LNK2019: unresolved external symbol __imp_gr_seg_advance_X referenced in function _hb_graphite2_shape

@LilyWangLL
Copy link
Contributor

LilyWangLL commented Feb 27, 2023

Pinging @quyykk for response. Is work still being done for this PR? Could you please also resolve the conflicts?

@quyykk quyykk force-pushed the update-harfbuzz-7.0.0 branch from 7a2dbff to 524bba7 Compare March 9, 2023 23:37
@quyykk
Copy link
Contributor Author

quyykk commented Mar 10, 2023

Sorry for the delay. I tested the features with windows and linux, they both work for me now. Please test again

@LilyWangLL LilyWangLL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:all-feature-testing labels Mar 10, 2023
@dan-shaw dan-shaw merged commit c43dbae into microsoft:master Mar 13, 2023
@quyykk quyykk deleted the update-harfbuzz-7.0.0 branch March 13, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LilyWangLL LilyWangLL

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quyykk @LilyWangLL @dan-shaw

Comments